Code Analysis

NEW POST: Laziness

mdpopescu — Sat, 29 Aug 2009 04:25:10 GMT

Wow... is this tool actually used by anyone in Microsoft? All the rules point to a site that has been shut down long ago (gotdotnet.com). For extra fun, have it analyze itself and marvel at the number of issues it finds (let's not forget the null reference exceptions that occur during the analyzing process).

This looks worse than the MVC sample fiasco you guys had a while ago.

NEW POST: Laziness

mdpopescu — Sat, 29 Aug 2009 04:15:39 GMT

I sincerely hope that whoever wrote the installer was not responsible for the application itself. There are 3 options when installing the application - typical, complete and custom - and they all install the same thing. This is a bad first impression.

NEW POST: FxCop 1.36 Bugs & Stability

hfrmobile — Sun, 12 Jul 2009 20:25:57 GMT

@sfun28: ... forgets when I've excluded warnings ...

Something similar happened to me today. But it this is no StyleCop bug! The missing ignored warning occurs e.g. if you rename a source file so StyleCop can't know it ;-) You'll get a message "Could not import all messages". It's correct in my situation.

NEW POST: FxCop 1.36 Bugs & Stability

hfrmobile — Fri, 10 Jul 2009 11:40:30 GMT

I am using FxCop 1.36 for a while and have no problems with it. It also does not "forget" settings. They're stored in YourName.FxCop files (XML). Maybe there is a problem with your Source control? ;-)

NEW POST: CA1811

hfrmobile — Fri, 10 Jul 2009 11:15:13 GMT

RuleFile : Performance Rules (String)
Info: "There is uncalled code that is not externally visible and is not a known runtime entry point. If this violation fires in error, please send a problem report to the Visual Studio Code Analysis team."

// ReSharper disable UnusedMember.Local
[Something("Test")]
private string Test
{
get { ... }
set { ... }
}
// ReSharper restore UnusedMember.Local

In this case this private property (or protected) is called/used via Reflection.

What is the best or suggested solution for such cases?

NEW POST: FxCop 1.36 Bugs & Stability

sfun28 — Wed, 01 Jul 2009 00:33:57 GMT

Folks,

just a general question - is there any upcoming bug fixes/stability work or a new release?

I find that FxCop often forgets when I've excluded warnings and I need to re-type my comments and exclude again. Also, it crashes more often than I'd like.
A few times I've gotten into a wierd state where I've had to completely rebuild my project file. Overall I find the tool to be temperamental and unreliable. However, it provides HUGE value. I just wish it were more stable.

NEW POST: 64 bit FXCOP bits

syedab — Tue, 16 Jun 2009 13:18:52 GMT

I need to test CAT.NET 64 bit binaries as a rule to FXCOP 64 bit binaries.

NEW POST: Open With setting

hfrmobile — Fri, 05 Jun 2009 07:52:18 GMT

An option which specifies which editor is used to open .cs files would be very nice (e.g. Location: file:///C:/Development/Projects/MyProject/trunk/Interfaces/Interfaces.Stub/SoapExceptionHelper.cs<95> (String))

I am developing on VS.NET 2005 and VS.NET 2008 projects and so both Visual Studios are installed on my machine. When I work with VS.NET 2005 and click on a .cs file in FxCop VS.NET 2008 will open ...

I'll prefer an neutral editor like Notepad++ for that.

NEW POST: 64 bit FXCOP bits

hfrmobile — Tue, 02 Jun 2009 07:17:41 GMT

Why do you need that? FxCop is a .NET application ...

NEW POST: Compact Framework

hfrmobile — Tue, 02 Jun 2009 07:16:18 GMT

I used FxCop with a .NET CF 1.0 (!) assembly and it worked.

Do you get an error message or what is the problem?

Info: "Required Framework: .NET Framework 2.0" means that that framework must be installed on your machine to execute the FxCop application. But it is also able to analyze .NET CF assemblies.

hth, hfrmobile

NEW POST: 64 bit FXCOP bits

syedab — Mon, 01 Jun 2009 11:54:13 GMT

Do we have 64 bit FXCOP bits?

NEW POST: Compact Framework

Bee — Mon, 18 May 2009 08:07:42 GMT

Sorry to ask again, but does anyone have an answer to this question?

NEW POST: Compact Framework

Bee — Mon, 11 May 2009 10:56:32 GMT

Can FxCop be used for .NET Compact Framework.

The following page suggests not:-

http://code.msdn.microsoft.com/codeanalysis/Release/ProjectReleases.aspx?ReleaseId=553

Supported Operating Systems: Windows 2000; Windows XP; Windows Vista; Windows 2000 Server; Windows Server 2003
Required Framework: .NET Framework 2.0

Please could I get some clarification.

NEW POST: Other tools?

dwright5816 — Mon, 09 Mar 2009 19:12:37 GMT

In our organization, we have to maintain an external document describing each of our standards, along with rationale behind them. It would be nice if we could just run a report from FxCop that shows our current configuration in a human readable format, along with rationale for each standard. We would like to be able to maintain the rationale, but if default rationale were available for each configuration option, that would be helpful, too. This way, we wouldn't have to maintain our standards in 2 places and manually synchronize them.

NEW POST: Can I find assignments using FxCop

halkar — Thu, 05 Feb 2009 13:33:08 GMT

Sorry if I'm writing in wrong discussion but I have one question.
I'm writing custom FxCop rule and I'd like to find all the statements like this:
object a;
a=null;
I'd want to find all statements where variable or field is assigned to null. How can I do this? Am I right, that I have to check in VisitAssignmentStatement method? But how can I find that second operand is null?

Thank you.

NEW POST: Rule to detect dead code

joujoukinder — Thu, 15 Jan 2009 16:32:55 GMT

Hello,

I am trying to program a rule into a DLL to detect dead code.

I can't get out with it.

I have a solution with 5 projects. I'd like to programm a rule that list all the methods and properties, even if public, that are never called.

Can you help me?

Thanks.

Best regards.

MS

NEW POST: False positives in CA1601 and CA1047

OliverHallam — Mon, 01 Dec 2008 17:49:42 GMT

If you define a class with a virtual or abstract method with generic parameters with restrictions, e.g.

abstract class C
{
abstract T M<T, U>() where U : IEnumerable<T>
}

then fxCop raises error CA1601 on any method overriding this, and CA1407 too if the overriding method is in a sealed class, and the method is protected.

NEW POST: Check namespace and methods type

Leviz — Wed, 12 Nov 2008 19:21:27 GMT

Hi,

I'm making my own Fxcop Rules.
I'm trying to check the namespace to see if I'm on the good class and after that, I want to ckeck if the methods are Statics or not.
I began the code but I'm blocked, because I think that my methods that check the namespace is called after the methods that ckecks if the methods are statics or not in my class.

Here is my Code :

public override ProblemCollection Check(string namespaceName, TypeNodeCollection types) {

try {

this._isBllNameSpace = false;
if (namespaceName.ToUpper().IndexOf(Constants.BLL_NAME) > 0) {
this._isBllNameSpace = true;
}
} catch (Exception e) {
return null;
}

return null;
}

public override ProblemCollection Check(Member member) {
bool failed = false;

try {

Method method = member as Method;

if (method == null)
return base.Check(member);

if (this._isBllNameSpace) {
//On check si le 'member' testé est une méthode
if (member.NodeType == NodeType.Method) {
failed = !method.IsStatic;
}
failed = true;
}

if (failed) {
base.Problems.Add(new Problem(base.GetResolution("This method is not STATIC"), method.Name));
return Problems;
} else {
return null;
}

} catch (Exception e) {
return null;
}
}

Can somebody help me to resolve my problem ?

First : check the namespace to see if we are in the good class
Then: check the methods to see if they are statics

Thanks for your help

NEW POST: return value (error code) for FxCopCmd.exe

hfrmobile — Wed, 12 Nov 2008 18:13:17 GMT

FxCopCmd.exe should return a value != 0 (%errorlevel%) when one or more rules failed.
This makes it easier to determine if all rules are OK or not (e.g. for automated builds like MSBuild, NAnt). If not all rules are OK the build should fail.

Workaround: Just test if the output-file exists or not (have to use /o: switch)

NEW POST: Command line support

hfrmobile — Wed, 12 Nov 2008 16:50:20 GMT

Thx, that's it (http://msdn.microsoft.com/en-us/library/bb429474(VS.80).aspx)

--hfr