sourceanalysis Work Item Rss Feed

COMMENTED ISSUE: Visual Studio 2010 Beta 1 support

jasonall — Thu, 19 Nov 2009 18:23:09 GMT

Is possible to use StyleCop using VS2010 B1?

Thanks,
Matteo.
Comments: Work is currently underway on a version of StyleCop that will integrate into the Visual Studio 2010 shell.

COMMENTED ISSUE: Visual Studio 2010 Beta 1 support

TATWORTH — Thu, 19 Nov 2009 15:34:38 GMT

Is possible to use StyleCop using VS2010 B1?

Thanks,
Matteo.
Comments: What about working with VS2010 Beta 2?

COMMENTED ISSUE: SA1636: Copyright character not matched in GlobalSuppressions.cs file.

rbratton — Thu, 12 Nov 2009 16:19:35 GMT

I have defined a copyright string in Settings.StyleCop using the copyright symbol "©". In every other C# file, the text is matched OK and I don't get a warning. In the GlobalSuppressions.cs file, StyleCop says the exact string is not found even though I cut and paste the text from files where there is no problem.

Then I looked at the Settings.StyleCop file itself. The copyright symbol is displayed as "Â©". When I put these 2 characters in place of the normal copyright symbol in the GlobalSuppressions.cs file, the warning does not appear. And it is only for the GlobalSuppressions.cs file that I have to use "Â©". All the other C# files pass with just the normal copyright symbol.
Comments: Yes, I saw that--maybe I should have added on to that one. Anyway, I thought I'd provide a little more information about the problem and the workaround I discovered. Thanks.

COMMENTED ISSUE: SA1636: Copyright character not matched in GlobalSuppressions.cs file.

olivier34 — Thu, 12 Nov 2009 12:47:36 GMT

I have defined a copyright string in Settings.StyleCop using the copyright symbol "©". In every other C# file, the text is matched OK and I don't get a warning. In the GlobalSuppressions.cs file, StyleCop says the exact string is not found even though I cut and paste the text from files where there is no problem.

Then I looked at the Settings.StyleCop file itself. The copyright symbol is displayed as "Â©". When I put these 2 characters in place of the normal copyright symbol in the GlobalSuppressions.cs file, the warning does not appear. And it is only for the GlobalSuppressions.cs file that I have to use "Â©". All the other C# files pass with just the normal copyright symbol.
Comments: Problem about the copyright char was asked before in this post (http://code.msdn.microsoft.com/sourceanalysis/Thread/View.aspx?ThreadId=394) but not responded...

CREATED ISSUE: SA1636: Copyright character not matched in GlobalSuppressions.cs file.

rbratton — Wed, 11 Nov 2009 23:52:01 GMT

CREATED ISSUE: Rule suggestion: File contains unused usings

ncalinoiu — Mon, 09 Nov 2009 16:07:37 GMT

If implemented, the rule should allow exclusion of certain namespace (e.g.: System) via configuration.

COMMENTED ISSUE: SA1600: explicit interface implementation do not need documentation

barriemcguire — Mon, 09 Nov 2009 15:34:39 GMT

For explicit implementation, the comments will not be shown anyway.

You won't see it in the class, and when cast to specified interface, the interface's comment will be shown.
Comments: I can see the logic behind this rule; as an interface could be implemented be several classes, each of which does something slightly different with each method - however in cases where the implementation logic is exactly as described by your interface documentation, you just end up having to mainting everything in two places. It would be very useful to perhaps have a sub-option of SA1600 to allow it to ignore explicit interface implementations.

COMMENTED ISSUE: SA1636 firing inappropriately

dnorthut — Fri, 06 Nov 2009 18:04:06 GMT

We are using Resharper 4.5 and StyleCop 4.3.

We have a project with many .CS files in it. All files were processed using Clean Code from Resharper. All files were modified to include an appropriate header as defined by StyleCop settings. Four of the many files consistently get an SA1636 on them. We cannot figure out why, and what the difference is between a file that receives no warning, and a file that does.
Comments: This appears to be caused by inclusion of the '©' symbol. If I replace it with '(c)' everything is fine.

CREATED ISSUE: SA1636 firing inappropriately

dnorthut — Fri, 06 Nov 2009 17:45:39 GMT

COMMENTED ISSUE: VS 2005 IDE consumes 99% CPU when opening large unmanaged solution after installing StyleCop 4.3

phildevaney — Fri, 06 Nov 2009 08:59:35 GMT

COMMENTED ISSUE: VS 2005 IDE consumes 99% CPU when opening large unmanaged solution after installing StyleCop 4.3

parky37 — Thu, 05 Nov 2009 07:24:16 GMT

After installing StyleCop 4.3, Visual Studio 2005 will consume 99% CPU (according to the Task Manager) when opening a large (~41 projects) solution containing mostly unmanaged C/C++ code. The CPU usage will occasionally drop to as low as 80%, but even after waiting several minutes while doing nothing, it did not drop down to an acceptable level.
This behaviour does not occur when opening a solution that consists of one C# project.
The CPU usage is so high it is almost impossible to select text in a source file, select menu items etc.
Uninstalling StyleCop resolves the issue with no other changes required.
Visual Studio is running in a standard user account (i.e. not an administrator account).
This issue is quite reproducible - I have installed and uninstalled StyleCop 4.3 several times to test this.
Comments: If this problem is still being looked into, here is a call stack on the main thread of devenv.exe. Hopefully, this will make more sense to you than it does to me: Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.GetProjectItemPath(EnvDTE.ProjectItem item = {System.__ComObject}) + 0x63 bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.EnumerateProjectItem(EnvDTE.ProjectItem item = {System.__ComObject}, string name = "nameofaprojectinalargesolution", Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectInvoker projectCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectItemInvoker projectItemCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, object projectContext, object fileContext) + 0x100 bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.EnumerateProjectItems(EnvDTE.ProjectItems items, string name = "nameofaprojectinalargesolution", Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectInvoker projectCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectItemInvoker projectItemCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, object projectContext = {Microsoft.StyleCop.VisualStudio.AnalysisHelper}, object fileContext = null) + 0x63 bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.EnumerateProjectItem(EnvDTE.ProjectItem item, string name, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectInvoker projectCallback, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectItemInvoker projectItemCallback, object projectContext, object fileContext) + 0xcf bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.EnumerateProjectItems(EnvDTE.ProjectItems items, string name = "nameofaprojectinalargesolution", Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectInvoker projectCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectItemInvoker projectItemCallback = {Method = Cannot evaluate expression because a native frame is on top of the call stack.}, object projectContext = {Microsoft.StyleCop.VisualStudio.AnalysisHelper}, object fileContext = null) + 0x63 bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.EnumerateProject(EnvDTE.Project project, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectInvoker projectCallback, Microsoft.StyleCop.VisualStudio.ProjectUtilities.ProjectItemInvoker projectItemCallback, object projectContext, object fileContext) + 0x149 bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.ProjectUtilities.SupportsStyleCop(Microsoft.StyleCop.VisualStudio.AnalysisHelper helper = {Microsoft.StyleCop.VisualStudio.AnalysisHelper}, Microsoft.StyleCop.VisualStudio.AnalysisType type) + 0x10f bytes Microsoft.StyleCop.VSPackage.dll!Microsoft.StyleCop.VisualStudio.PackageCommandSet.StatusAnalyzeSolution(object sender = {Microsoft.VisualStudio.Shell.OleMenuCommand}, System.EventArgs eventArgs) + 0x15 bytes Microsoft.VisualStudio.Shell.dll!Microsoft.VisualStudio.Shell.OleMenuCommand.OleStatus.get() + 0x29 bytes Microsoft.VisualStudio.Shell.dll!Microsoft.VisualStudio.Shell.OleMenuCommandService.Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget.QueryStatus(ref System.Guid guidGroup = {System.Guid}, uint nCmdId, Microsoft.VisualStudio.OLE.Interop.OLECMD[] oleCmd = {Microsoft.VisualStudio.OLE.Interop.OLECMD[1]}, System.IntPtr oleText = 45349544) + 0x166 bytes Microsoft.VisualStudio.Shell.dll!Microsoft.VisualStudio.Shell.Package.Microsoft.VisualStudio.OLE.Interop.IOleCommandTarget.QueryStatus(ref System.Guid guidGroup, uint nCmdId, Microsoft.VisualStudio.OLE.Interop.OLECMD[] oleCmd, System.IntPtr oleText) + 0x47 bytes I'd really like to be able to use StyleCop again. Unfortunately, my company's main product is a large game composed of C++ projects so having nicely formatted source code files for the little tools I write isn't worth the suffering.

COMMENTED ISSUE: Syntax error warning calling methods on integer literals

bhazzard — Wed, 04 Nov 2009 19:58:09 GMT

Hi,

StyleCop is giving me the error: "SA0102: A syntax error has been discovered in file..." for lines of code where i use an extension method on an integer literal or a string literal such as:

100.Times( i => doSomething(i));
// or
"hello".Length
Comments: I also have this issue for extension methods on integer literals: 10.PercentOf(20); // which would return 2

COMMENTED ISSUE: VS 2005 IDE consumes 99% CPU when opening large unmanaged solution after installing StyleCop 4.3

phildevaney — Wed, 04 Nov 2009 08:45:17 GMT

CREATED ISSUE: Syntax error on unsafe code

lynnnoton — Fri, 30 Oct 2009 03:20:17 GMT

We have a block of unsafe code, and StyleCop is issuing a syntax error when attempting to parse that file.

namespace TestWPF
{
class Test
{
void testError()
{
unsafe
{
int*[] ptrArray = new int*[10];
}
}
}
}

SA0102: A syntax error has been discovered in file Test.cs on line 9.

I have attempted to do the things listed here (http://sergeyshishkin.spaces.live.com/blog/cns!9F19E53BA9C1D63F!253.entry) to get StyleCop to ignore that file or function, but none of them worked. I still get the syntax error.

COMMENTED ISSUE: excluded Hungarian prefixes not obeyed in console MSbuild build

nathanfunk — Thu, 29 Oct 2009 17:37:33 GMT

Have configured csproj files to include the StyleCop targets by adding an import element to the project xml.

However, if the solution is compiled in the console using msbuild.exe, warnings are being raised in the console against valiable names like isValid, toCopy etc, where this does not occur in the IDE.

This is using StyleCop 4.3
Comments: I am seeing the same issue. When I click on the Hungarian tab in the settings editor, I see "is" listed as one of the 11 excluded prefixes. But when I build my code I still get a SA1305 warnings for variable names. My configuration file is in D:\a\b\, the solution is in D:\a\b\c\d\, the project in D:\a\b\c\d\e\ and the offending source file is in D:\a\b\c\d\e\f\. All other settings options are being honored. I am using Stylecop 4.3.2.1. I have also ensured that there are no additional settings files in the path. I have discovered a workaround which indicates that Stylecop is not using the defaults properly, but will respect Hungarian prefix settings if explicitly added to the settings file. WORKAROUND: By adding the following to my Stylecop.Settings file, the Hungarian prefix settings are honored. <Analyzer AnalyzerId="Microsoft.StyleCop.CSharp.NamingRules"> <AnalyzerSettings> <CollectionProperty Name="Hungarian"> <Value>as</Value> <Value>do</Value> <Value>id</Value> <Value>if</Value> <Value>in</Value> <Value>is</Value> <Value>my</Value> <Value>no</Value> <Value>on</Value> <Value>to</Value> <Value>ui</Value> </CollectionProperty> </AnalyzerSettings> </Analyzer>

CREATED ISSUE: Unnamed syntax error

fabiomilheiro — Mon, 26 Oct 2009 23:09:50 GMT

When I have an abstract class like this: public abstract DataSet ListMenuCategories(string id)

and I try to implement it like this:
public abstract DataSet ListMenuCategories(string id)
instead of
public override DataSet ListMenuCategories(string id)

Stylecop doesn't name the error. Simply states that there is an error which is still fine, but I thought maybe you'd like to improve.

Warning 1 SA0102: A syntax error has been discovered in file F:.......cs on line 117. F:...........cs 117 1

Thank you, this is an EXCELLENT tool!

CREATED ISSUE: doesn't handle pointers (or is there a way to enable /unsafe+?)

jasonall — Thu, 22 Oct 2009 21:06:57 GMT

See original thread for more details: https://code.msdn.microsoft.com/Thread/View.aspx?ProjectName=sourceanalysis&ThreadId=397&wa=wsignin1.0

sgraham wrote:

Will you please let us know whether this statement is located within an unsafe block?

Ah, I see. The whole assembly is unsafe, I guess (as in csc.exe is invoked with /unsafe+), but that typeof isn't inside of an unsafe block. I don't think that's an error (just taking the type of a pointer, rather than actually using a pointer), but I'm not especially sure. Anyway, csc doesn't report a syntax error/warning, but then StyleCop says there's a syntax error, which is why I mentioned it.

scott

This is probably a limitation in the tool. Your whole assembly is unsafe, but currently Source Analysis only operates on C# files and doesn't have knowledge about special settings in the project or attributes defined in other source files.

COMMENTED ISSUE: SA1603 checks XML within comments that are in Quotations

MikeHofer — Thu, 22 Oct 2009 15:42:13 GMT

SA1603 should ignore any XML that is in comments in quotations.

Ie, it is complaining about the <Ect> below even though it is in quotes from the cref:

/// <summary>
/// Implements <see cref="ICts.Receive(ICollection<Ect> eTr)"/>
/// </summary>

Comments: This also appears when StyleCop encounters XML in my *code*. It thinks the XML marker symbols ("<" and ">") are comment headers, and tells me they are invalid. For example, the following lines generate SA 1603: public bool IsLesssThanEqualTo { get { return Is("<="); } } public bool IsLessThan { get { return Is("< "); } } public bool IsNotEqual { get { return Is("<> "); } } public bool IsConcatenate { get { return Is("&"); } } public bool IsLesssThanEqualTo { get { return Is("<="); } } public bool IsLessThan { get { return Is("< "); } } public bool IsNotEqual { get { return Is("<>"); } } These are clearly method calls, and not documentation comments. In the short term, I'm disabling the rule check, but this needs to be fixed.

COMMENTED ISSUE: VS 2005 IDE consumes 99% CPU when opening large unmanaged solution after installing StyleCop 4.3

DRieman — Wed, 21 Oct 2009 22:59:56 GMT

COMMENTED ISSUE: Package 'Visual Studio Explorers and Designers Package' has failed to load

kjbartel — Wed, 21 Oct 2009 00:56:02 GMT

I installed Source Code Analysis for C# (SCA) today.
Now when I open a solution in VS 2008 TS I get the following message 3 time the output window.

VSIP: Package 'Visual Studio Explorers and Designers Package' has failed to load ( GUID = {8D8529D3-625D-4496-8354-3DAD630ECC1B} ).
Please contact package vendor for assistance.

Is this due to SCA or is there something else going on?

Comments: This issue still exists in 4.3.2. Uninstalling StyleCop fixed the issue.